feat: test tools from the UI, user activity log, one clients page, prune stale tools #27
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/open-issues-23-26"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #23, closes #24, closes #25, closes #26.
Summary
#23 Test a tool. There is a Test button on the admin Tools tab and on the portal server page. It opens a form built from the tool's
inputSchema, with a JSON fallback for schemas the form can't render./mcp/admin(adminMcp: false).checkToolCallandrecordToolCallare pulled out ofcallGatewayTool;/mcpbehaves the same as before.#24 Own logs.
GET /api/me/tool-callsand a portal Activity page show only the user's own tool calls (filters: server, status).#25 One Clients page.
/connectredirects to/clients?connect=1.#26 Stale tools.
Disabled rows that are no longer listed are kept and marked "Not listed at the last refresh" in the admin Tools tab. The gateway treats a tool missing from the catalog as enabled, so deleting them would let a Test run on narrower test values switch a disabled tool back on for real users. This differs from the "hard delete everything" option agreed earlier: review found that hole.
Evidence
After:
upstream-pool.test.tschecks that enabled tools the server no longer lists are dropped and disabled ones are kept, including on an empty list.tool-test-calls.test.ts(14 tests): admin and user paths, disabled, hidden, no access, 404, 409,isError, per-user test values, rows logged without arguments.my-tool-calls.test.ts: a user sees only their own rows,?userId=is ignored, filters, paging, shared-server error masking.toolForm.test.ts, the ServerPage modal flow,ActivityPage.test.tsx,ClientsPage.test.tsx(button,?connect=1,/connectredirect).trail checkflags README.md:13 and schema.ts:356 against the "no admin tools on the user /mcp gateway" learning. Both are keyword matches: nothing is added to/mcp, and the new admin call route is excluded from the admin MCP.Merge Danger
Door: two-way
No migration. The routes, pages and catalog rule are all revertible. Catalog rows deleted by a refresh come back on the next refresh that lists them.
Blast Radius: moderate
gateway.test.ts)./connectlinks redirect.🤖 Generated with Claude Code